Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to CMakeLists #429

Merged
merged 4 commits into from
Jul 9, 2023
Merged

Changes to CMakeLists #429

merged 4 commits into from
Jul 9, 2023

Conversation

CBenghi
Copy link
Contributor

@CBenghi CBenghi commented Jul 1, 2023

  • added vs2022 settings
  • standardised param_setter function
  • added regression suite executable (early draft)

also minor geometryLoader cleanup.

- added vs2022 settings
- standardised param_setter function
- added regression suite executable (early draft)

also minor geometryLoader cleanup.
@beachtom beachtom self-requested a review July 3, 2023 07:42
@beachtom
Copy link
Collaborator

beachtom commented Jul 4, 2023

@CBenghi happy to merge as is.

Would it be possible to also configure the benchmarking (in a future PR) to check if the number of vertexes etc.. change. This is not obviously fully robust - but if it changes it may at least indicate we need to check it manually

@CBenghi
Copy link
Contributor Author

CBenghi commented Jul 4, 2023

Sure,
I'm working on it today, will update the PR later.

@CBenghi
Copy link
Contributor Author

CBenghi commented Jul 4, 2023

Hi @beachtom,

I've improved the regression app structure and the output. Command line options work as follows:

Command line options are:
  benchmark <source>        geometry performance evaluation of ifc files in folder
  benchmarktable <source>   geometry performance evaluation (tab separated, one line per file)
  help                      prints this help

  <source>                  can be either an ifc file or a folder

In case the program hangs, ctrl-c reports the geometry entity being meshed.

The benchmark command returns a verbose report like the following:

Processing c:\Data\Ifc\_DebugSupport\19027 ARC COS.ifc
 - size is 23,406,412 bytes.
 - Reading and loading took 3,095 ms.
 - Generating geometry took 6,641 msec.
 - Total processing took 9,737 msec.
 - 2,376,387 vertices count.
 - 792,129 indices count.
 - 0 errors.
 - 501 entities.

Processing c:\Data\Ifc\_DebugSupport\NBG1-09-D-Z1-3M-GA5100-001-B.ifc
 - size is 95,020 bytes.
 - Reading and loading took 43 ms.
 - Generating geometry took 6 msec.
 - Total processing took 50 msec.
 - 1,728 vertices count.
 - 576 indices count.
 - 0 errors.
 - 28 entities.


Results:
 - c:\Data\Ifc\_DebugSupport\19027 ARC COS.ifc: 2.40386 MB/sec
 - c:\Data\Ifc\_DebugSupport\NBG1-09-D-Z1-3M-GA5100-001-B.ifc: 1.9004 MB/sec

Average: 2.15213 MB/sec

while benchmarktable option returns a compact table (tab separated to be copied to excel or similar):

File    bytes   size    reading msec    geom msec       total msec      vertices count  indexes count   error count     entity count
c:\Data\Ifc\_DebugSupport\19027 ARC COS.ifc     23406412        22.3221 Mb      2233    6289    8523    2376387 792129  0       501
c:\Data\Ifc\_DebugSupport\NBG1-09-D-Z1-3M-GA5100-001-B.ifc      95020   92.793 Kb       50      10      61      1728    576     0       28   

Results:
 - c:\Data\Ifc\_DebugSupport\19027 ARC COS.ifc: 2.74626 MB/sec
 - c:\Data\Ifc\_DebugSupport\NBG1-09-D-Z1-3M-GA5100-001-B.ifc: 1.5577 MB/sec

Average: 2.15198 MB/sec

@beachtom beachtom merged commit 970a261 into ThatOpen:main Jul 9, 2023
4 checks passed
@CBenghi CBenghi deleted the cmake/vs branch July 9, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants