Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pleiades NEO harvesting support #22

Merged
merged 20 commits into from
Aug 28, 2023
Merged

Pleiades NEO harvesting support #22

merged 20 commits into from
Aug 28, 2023

Conversation

bbrauzzi
Copy link
Contributor

@bbrauzzi bbrauzzi commented Aug 4, 2023

STARS support for Pleiades NEO products

mlongobardo-gituname and others added 15 commits July 12, 2023 16:49
@emmanuelmathot emmanuelmathot changed the title Feature/esacpe 1597 Pleiades NEO harvesting support Aug 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #22 (248b3b8) into develop (6266389) will decrease coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is 13.97%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #22      +/-   ##
===========================================
- Coverage    14.25%   14.24%   -0.01%     
===========================================
  Files          236      237       +1     
  Lines        33904    33968      +64     
  Branches      2848     2854       +6     
===========================================
+ Hits          4834     4840       +6     
- Misses       29069    29127      +58     
  Partials         1        1
Flag Coverage Δ
unittests 14.24% <13.97%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../Model/Metadata/Airbus/PleiadesNEODimapProfiler.cs 0.00% <0.00%> (ø)
....Data/Model/Metadata/Airbus/Schemas/AirbusDimap.cs 0.00% <ø> (ø)
...a/Model/Metadata/Airbus/AirbusMetadataExtractor.cs 13.87% <19.51%> (+0.28%) ⬆️
...Stars.Data/Model/Metadata/Airbus/AirbusProfiler.cs 10.52% <23.80%> (+0.52%) ⬆️

@emmanuelmathot emmanuelmathot self-requested a review August 23, 2023 09:30
@bbrauzzi
GetProvider method update + GetResolution for PNEO
9bd6b27 
Refactoring: GetProvider method changed to GetProviders
GetResolution for PNEO: makes mean of GSD_ACROSS_TRACK and
GSD_ALONG_TRACK and rounds it to 2 decimals
@bbrauzzi
PNEO centerWavelength and fullWidthHalfMax
0e50fa3
@bbrauzzi
ESACPE-1597 #comment Pleiades NEO support for PMS-FS and MS-FS spectr…
6f0d97a 
…alProcessing
@bbrauzzi
revert comented line WriteJson
a7635bf
@emmanuelmathot emmanuelmathot self-requested a review August 28, 2023 08:14
emmanuelmathot
emmanuelmathot approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@emmanuelmathot emmanuelmathot merged commit 4869684 into develop Aug 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelmathot emmanuelmathot emmanuelmathot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbrauzzi @codecov-commenter @emmanuelmathot