Skip to content

Commit

Permalink
Fixed #1013 set param T_subseq_isconstant to default None in `co…
Browse files Browse the repository at this point in the history
…re.process_isconstant` (#1016)

* set param to default None

* test default mode of function
  • Loading branch information
NimaSarajpoor committed Jul 27, 2024
1 parent 121cf5d commit fb9a125
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 1 deletion.
2 changes: 1 addition & 1 deletion stumpy/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -4221,7 +4221,7 @@ def _mpdist(
return MPdist


def process_isconstant(T, m, T_subseq_isconstant, T_subseq_isfinite=None):
def process_isconstant(T, m, T_subseq_isconstant=None, T_subseq_isfinite=None):
"""
A convenience wrapper around the `rolling_isconstant` and
`fix_isconstant_isfinite_conflicts`.
Expand Down
25 changes: 25 additions & 0 deletions tests/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -1753,3 +1753,28 @@ def test_process_isconstant_2d():
T_subseq_isconstant_comp = core.process_isconstant(T, m, T_subseq_isconstant)

npt.assert_array_equal(T_subseq_isconstant_ref, T_subseq_isconstant_comp)


def test_process_isconstant_1d_default():
# test the default value of `T_subseq_isconstant` in `process_isconstant`
n = 64
m = 8

# case 1: without nan
T = np.random.rand(n)
T[:m] = 0.5 # constant subsequence

T_subseq_isconstant_ref = naive.rolling_isconstant(T, m, a_subseq_isconstant=None)
T_subseq_isconstant_comp = core.process_isconstant(T, m, T_subseq_isconstant=None)

npt.assert_array_equal(T_subseq_isconstant_ref, T_subseq_isconstant_comp)

# case 2: with nan
T = np.random.rand(n)
T[:m] = 0.5 # constant subsequence
T[-m:] = np.nan # non-finite subsequence

T_subseq_isconstant_ref = naive.rolling_isconstant(T, m, a_subseq_isconstant=None)
T_subseq_isconstant_comp = core.process_isconstant(T, m, T_subseq_isconstant=None)

npt.assert_array_equal(T_subseq_isconstant_ref, T_subseq_isconstant_comp)

0 comments on commit fb9a125

Please sign in to comment.