Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests working on github #20

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Get tests working on github #20

wants to merge 12 commits into from

Conversation

rbooth200
Copy link
Collaborator

This pull request fixes the automatic tests and sets up Github to run them automatically on pushes

@rbooth200 rbooth200 requested a review from Schulik July 5, 2023 13:59
Copy link
Owner

@Schulik Schulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed everything, as in this merge request github seems to double-count a ton of code, but probably as the code is working mostly fine. I'd just request to roll back some of the loop maximum changes from num_cells+2 to num_cells+1, as the last ghost cell often creates problems, and doesn't need to be updated in some cases anyway (like the rad transport)

@rbooth200
Copy link
Collaborator Author

I can't because the collisional heating test with radiative transfer fails if I do. The problem is that with a limit of ncells+1 the temperature of the last ghost cell is not constrained, resulting in a singular matrix.

With the current implementation the hydro works properly, as demonstrated by the shock-tube tests, and the radiation works properly as demonstrated by the irradiation tests, so I don't think there is really a problem with the current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants