build: Windows build warnings and build script fix

SAP · Apr 20, 2023 · 9428e0c · 9428e0c
1 parent 7586033
commit 9428e0c
Show file tree

Hide file tree

Showing 4 changed files with 108 additions and 61 deletions.
diff --git a/ci/utils/build.ps1 b/ci/utils/build.ps1
@@ -10,21 +10,25 @@
 
 $python_versions = "3.7.9 3.8.10 3.9.13 3.10.10 3.11.2"
 
-$PYRFC_BUILD_CYTHON="yes"
+$env:PYRFC_BUILD_CYTHON="yes"
 
 $action=$args[0]
 
 $python_versions.Split(" ") | ForEach {
     $version = $_
-    Write-Output $version
-    pyenv global $version
+
+    pyenv shell $version
+    python -V
+
     If($action -eq "pip") {
         python -m pip install --upgrade pip
     } else {
         If($action -ne "test") {
-            python setup.py bdist_wheel
+            python setup.py bdist_wheel 
             pip install --upgrade --force --find-links=dist pyrfc
         }
-        pytest -vvx
+        If($action -ne "skip-test") {
+            pytest -vvx
+        }
     }
 }
diff --git a/src/pyrfc/_cyrfc.cpp b/src/pyrfc/_cyrfc.cpp
diff --git a/src/pyrfc/data_container.pyx b/src/pyrfc/data_container.pyx
@@ -252,7 +252,7 @@ cdef SAP_UC* fillString(pyuc) except NULL:
     cdef RFC_RC rc
     cdef RFC_ERROR_INFO errorInfo
     ucbytes = pyuc.encode()
-    cdef unsigned ucbytes_len = len(ucbytes)
+    cdef unsigned ucbytes_len = <unsigned> len(ucbytes)
     cdef unsigned sapuc_size = ucbytes_len + 1
     cdef SAP_UC* sapuc = mallocU(sapuc_size)
     sapuc[0] = 0

diff --git a/src/pyrfc/nwrfcsdk.pyx b/src/pyrfc/nwrfcsdk.pyx
@@ -199,7 +199,7 @@ cdef class ConnectionParameters:
     cdef RFC_CONNECTION_PARAMETER *_params
 
     def __cinit__(self, **params):
-        self._params_count = len(params)
+        self._params_count = <unsigned> len(params)
         if self._params_count < 1:
             raise RFCError("Connection parameters missing")
         self._params = <RFC_CONNECTION_PARAMETER*> malloc(self._params_count * sizeof(RFC_CONNECTION_PARAMETER))