WIP: NTRU Prime #35
Open
WIP: NTRU Prime #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At this point streamlined ntru implementation is almost compete and what is left is fixing some maths bugs in decap and making sure that all NIST tests are passing. then I have to slowly rework the API while making sure that all tests still pass |
added 10 commits
July 8, 2024 00:00
This patch creates empty crate for ntru prime and adds test data taken from nist Signed-off-by: Ahmed <>
1- compile for no-std 2- allow some warnings, while being pedantic regarding other warnings Signed-off-by: Ahmed <>
That include 1- constant time if else 2- constant time division 3- constant time bitonic sort Signed-off-by: Ahmed <>
Signed-off-by: Ahmed <>
Signed-off-by: Ahmed <>
Signed-off-by: Ahmed <>
Signed-off-by: Ahmed <>
Signed-off-by: Ahmed <>
Signed-off-by: Ahmed <>
Signed-off-by: Ahmed <>
|
So working implementation should be complete at least for streamlined ntru including tests. API is less than ideal and comes with no documentation and does not use the KEM crate. also LWE variant is not implemented yet. I will try to move 87c7c02 to subtle, I am not sure if they would be interested in having sorting algorithm there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aside from finishing the implementation few things that I would like to also do
1- adapt/move the whole constant_time module to
subtle.2- more tests (& fuzzing when the input space too big to exhaust) to algebra since most of it is not tested and I found lots of bugs in the parts I tested.
3- add benchmarks.
4- see if replacing loops with maps improves performance considerably.
5- more
debug_assertsI will probably take a full round of revision following the specs and the sage implementation to see what properties should hold where.Things I am not confident about:
1- the down casts (i32 to i16 ...etc)
2- the casting across signs (i32 to u32....etc)