Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and updates to bring up to ruby 3, contenful-migrations 3.0 etc. #3

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Fixes and updates to bring up to ruby 3, contenful-migrations 3.0 etc. #3

wants to merge 28 commits into from

Conversation

patch0
Copy link

@patch0 patch0 commented Nov 10, 2021 •
edited
Loading

What's changed

  • Fixed keyword argument syntax that has been removed in ruby 3.0 -- this was mostly in calls to Contentful::Migrator#new.
  • Bumped contentful-management.rb dependency to v3.0
  • Bump ruby target versions (2.7+)
  • Added CircleCI tasks
  • Bumped gem version to 0.2.0
  • Moved the #constantize and #camelcase methods to a refinement on the String class
  • Ran rubocop -A over the whole codebase
  • Updated .rubocop.yml to be less opinionated, and added .rubocop_todo.yml

patch0 and others added 28 commits November 10, 2021 09:28
@patch0
Remove load rake task
cd8d63a
@patch0
Replace rake loading with railtie
f53fd00
@patch0
Use rails env
6e36bcd
@patch0
Fix path for generator
b9cd6a1
@patch0
In Ruby 3, named params need to be splatted
e1adab6
@patch0
Upgrade contentful-management gem to v3
1436e83 
Also remove rubocop config
@patch0
Mega refactor
c7bf4c1
@patch0
Version bump to v0.2.0
3b7aff3
@patch0
Add circle ci
a91cefc
@patch0
Fix version
589a40c
@patch0
Add junit formatter for circleci
31c34f9
@patch0
Add a standard rubocop config
22193de
@patch0
Tidy rubocop config a little
06be75b
@patch0
Add rubocop todo file
826e1b3
@patch0
Raise errors by default in the Contentful::Management::Client
5fe97c0 
This ensures that migrations bail out when errors are returned,
lessening the chance of failed migrations
@patch0
Move env vars back; ensure they're there and use ClimateControl in tests
178769c
@patch0
Refactor MigrationContentType so that errors raised by contentful are…
9a2dc5c 
… caught
@patch0
Refactor tests for ContentfulMigrations::Migrator
dfdeba9
@patch0
Use environment where we mean it; move default content type name
1db76a6 
We're really operating on environments, so lets call them that.
@patch0
Set the default locale on the client for the migration content type
42fd001
@patch0
Poke the config directly
22918e0
@patch0
Try setting the default locale on the environment instead
4e06044
@patch0
Use the locale's code.
891d4b0
@patch0
Silence our friend, Rubocop
98e8033
@patch0
Add in a mass of mocks to allow tests to pass
568a58c
@patch0
Bump version number
5051ed5
@patch0
Also bump the Gemfile
aa43f97
@patch0
Merge pull request #5 from RaspberryPiFoundation/find-and-use-the-def…
4776f28 
…ault-locale-when-recording-migrations

Find and use the default locale when recording migrations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@patch0