Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix electrum resolve_height for offchain TXs #214

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

zoedberg
Copy link
Contributor

In the PR #198, specifically in the commit eeb9d55, the refactor removed an important part in the resolve_height method of the electrum resolver. The check of No such mempool or blockchain transaction error was there to detect offchain transactions. I've re-added the check so that know the behavior of the electrum resolver is the same of the esplora one.

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 0.0%. Comparing base (062964a) to head (2cd242a).
Report is 1 commits behind head on master.

Files Patch % Lines
src/resolvers/electrum_blocking.rs 0.0% 10 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##           master   #214   +/-   ##
=====================================
  Coverage     0.0%   0.0%           
=====================================
  Files          10     10           
  Lines         913    924   +11     
=====================================
- Misses        913    924   +11     
Flag Coverage Δ
rust 0.0% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small stylistic improvement, otherwise looks good

src/resolvers/electrum_blocking.rs Show resolved Hide resolved
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jun 24, 2024
@dr-orlovsky dr-orlovsky added the bug Something isn't working label Jun 24, 2024
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2cd242a

@dr-orlovsky dr-orlovsky merged commit 1c1844c into RGB-WG:master Jun 25, 2024
18 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants