make resolvers configurable #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoedberg
force-pushed
the
configurable_resolvers
branch
from
47d79f6
to
e00c837
Compare
|
patch updated, PR ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we allow RGB users to set a custom configuration for the resolvers. This feature could be useful especially for mobile clients, where the default timeout (30 seconds) could be too high.
Since electrum and esplora crates have different ways to instantiate a new client I've also made this BP-WG/bp-esplora-client#5 to add a
Configto esplora, making it more similar to the electrum client. For this reason this PR is in draft, once that will be merged I'll revert the patch and undraft this.Note: this PR also fixes the build (which was broken due to a force push in bp-core).