Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #3

Merged
merged 10 commits into from
Mar 25, 2024
Merged

Maintenance #3

merged 10 commits into from
Mar 25, 2024

Conversation

mbway
Copy link
Collaborator

@mbway mbway commented Mar 24, 2024

Updates linters and raises the minimum maturin and python versions.

The minimum maturin version is now 1.5.0 where maturin develop first creates editable installs.

Python 3.8 is still supported for another 7 months (source) but the import hook having a higher requirement than maturin isn't necessarily a problem (maturin itself has a higher requirement than pyo3). Raising the minimum to 3.9 simplifies some things.

@mbway
Copy link
Collaborator Author

mbway commented Mar 24, 2024

It seems there is an issue with the CI setup (perhaps the generated matrix is wrong). I'll look into it

@mbway mbway force-pushed the maintenance branch 10 times, most recently from 4a8512f to f159ee4 Compare March 24, 2024 20:01
@mbway mbway added CI-test-all Test on every supported platform CI-no-fail-fast Do not stop testing at the first failure labels Mar 24, 2024
@mbway mbway mentioned this pull request Mar 24, 2024
@mbway mbway requested a review from messense March 24, 2024 22:37
@messense messense merged commit 5abc45e into PyO3:main Mar 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Do not stop testing at the first failure CI-test-all Test on every supported platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants