[BUG] Failed test case due to different ordering caused by identical scores #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lthoang
force-pushed
the
fix-test-recommender-identical-scores
branch
from
63d2e10
to
c942d13
Compare
|
Interesting. Does it mean that sorting was not deterministic for the same list even though the input was in the same order? |
lthoang
force-pushed
the
fix-test-recommender-identical-scores
branch
from
c942d13
to
5294b18
Compare
Yes. It may due to different OS. |
lthoang
force-pushed
the
fix-test-recommender-identical-scores
branch
from
5294b18
to
eb16fcf
Compare
tqtg
reviewed
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
#621
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).