Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update api doc #33

Merged
merged 8 commits into from
Nov 30, 2018
Merged

Update api doc #33

merged 8 commits into from
Nov 30, 2018

Conversation

billPortalNetwork
Copy link
Contributor

@billPortalNetwork billPortalNetwork commented Nov 30, 2018 •
edited by PhyrexTsai
Loading

resolve #16

PhyrexTsai
PhyrexTsai reviewed Nov 30, 2018
View reviewed changes
api.md Outdated
```javascript
const Ethereum = require("../../lib/BNS").Ethereum
const ethereum = new Ethereum({
restURL: `https://mainnet.infura.io`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there missing networkId?

@PhyrexTsai PhyrexTsai merged commit caf64e9 into PortalNetwork:develop Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhyrexTsai PhyrexTsai PhyrexTsai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billPortalNetwork @PhyrexTsai