Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include "object" in getType #321

Open
wants to merge 1 commit into
base: rolling
Choose a base branch
from

Conversation

Rezenders
Copy link
Contributor

Return the "object" type in the getType method, as instances could be defined with the object type since it is included by default.

Also, I don´t understand why the following is necessary:

// We need to populate the constants of all supertypes
while(t->supertype != nullptr) {
t = t->supertype;
t->constants.insert(ts[i]);
}

It basically creates duplicates of the constants for all its supertypes. Is this really needed?

Related to #317

@Rezenders Rezenders marked this pull request as ready for review September 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant