Fix to have constants and numeric fluents in the goal #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uncions/constants/types declared to avoid printing the entry, thus generating a valid PDDL file
|
Thanks for the PR @roveri-marco . I hope to have fixed the CI next week. Now it is failing for other reasons.... |
|
CI seems to be fixed, but it is applying old pipeline. Can you rebase/merge? |
|
@fmrico I'm not able to understand why some tests fail. It seems the failure is not related to the changes. Can you help me in isolating the cause if this PR is the cause of the failure? |
|
Let me check... |
|
CI is passing now. I don't know if any tests are necessary to verify that this continues working after future changes. If you consider it necessary, please, open a new PR Thanks!!! merging 🚀 |
|
If needed. I'll add a new PR. Thanks. |
robodrome
added a commit
to robodrome/ros2_planning_system
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull I fixed the possibility to have constants in the predicates/functions while setting them, and in the goal.
This will close #261