Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FindEigen3.cmake is not used #126

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Ensure FindEigen3.cmake is not used #126

merged 1 commit into from
Feb 26, 2024

Conversation

ChrisThrasher
Copy link
Collaborator

Oversight from #125 since we don't test the install interface on RHEL.

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (4e73bb0) to head (c8a0701).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files          11       11           
  Lines         223      223           
=======================================
  Hits          220      220           
  Misses          3        3           
Flag Coverage Δ
humble 98.65% <ø> (ø)
rolling 98.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisThrasher
Copy link
Collaborator Author

ChrisThrasher commented Feb 25, 2024

@christophfroehlich Would you please try this out for me? If you check out main and run the tests on RHEL I suspect you'll find this bug. The unit tests install then consume the library and that tends to find issues like this. If those tests fail as expected then you can check out this branch and confirm they pass to verify this PR is correct.

@christophfroehlich
Copy link
Contributor

I have RSL, generate_parameter_library, and cpp_polyfills in my workspace. With the main branch:

# colcon build
Starting >>> tcb_span
Starting >>> tl_expected               
Starting >>> generate_parameter_library_py                              
Finished <<< tl_expected [1.60s]                                                                                                 
Finished <<< generate_parameter_library_py [1.73s]                                                  
Finished <<< tcb_span [8.98s]                      
Starting >>> rsl
Finished <<< rsl [2.35s]                      
Starting >>> parameter_traits
--- stderr: parameter_traits                          
CMake Error at CMakeLists.txt:8 (find_package):
  Found package configuration file:

    /opt/ros2_ws/install/rsl/share/rsl/cmake/rsl-config.cmake

  but it set rsl_FOUND to FALSE so package "rsl" is considered to be NOT
  FOUND.  Reason given by package:

  rsl could not be found because dependency Eigen3 could not be found.
---
Failed   <<< parameter_traits [0.80s, exited with code 1]

With this fix, it builds and colcon test succeeds also. Same with downstream control_toolbox package, so I guess this fixes my workflow mentioned in #114.

Thanks again for fixing this!

Copy link

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sjahr sjahr merged commit e93c545 into main Feb 26, 2024
37 checks passed
@delete-merged-branch delete-merged-branch bot deleted the eigen branch February 26, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants