Subontology #31
Open
Subontology #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holtgrewe
reviewed
Dec 22, 2017
| import java.util.HashSet; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.*; |
| expectedSize=1; | ||
| assertEquals(expectedSize,relationMap.size()); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove superflous empty lines.
| return new ImmutableOntology<T, R>(metaInfo, subGraph, subOntologyRoot, | ||
| Sets.intersection(nonObsoleteTermIds, childTermIds), | ||
| Sets.intersection(obsoleteTermIds, childTermIds), termMap, relationMap); | ||
| Set<TermId> intersectingTerms = Sets.intersection(nonObsoleteTermIds,childTermIds); |
There was a problem hiding this comment.
Whitespace is inconsistent. Your IDE should be able to help you with auto-formatting.
|
This Javadoc behavior should be changed When client code creates a subontology, e.g., all phenotype terms, then there are many situations where one needs to iterate over all of the terms and it is useful to use the TermMap for this purpose. It is not useful to have an ontology and a term map that are not consistent with one another. I think we should change this behavior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added code that makes the TermMap and the ReleationMap of subontologies created with the function subOntology in ImmuntableOntology containly only there terms and relations of the suibontology (previously, they contained the terms of the original ontology). I have added a line to the metadata that says that the ontology was subsetted.