-
Notifications
You must be signed in to change notification settings - Fork 27
refactor(examples/autoscale): Autoscale example refactor #228
Conversation
} | ||
} | ||
# Autoscale | ||
autoscale_regional_mig = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This param can be moved to per autoscale deployment configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this parameters was left intentionally there - because otherwise this section of the code would have become a lot more complicated due to the fact that we need to iterate over autoscale
variable within lb_internal
module :
backend_instance_groups = var.autoscale_regional_mig ? { for v in each.value.backends : v => module.autoscale[v].regional_instance_group_id } : merge([
for v in each.value.backends :
{
for z_k, z_v in var.autoscale[v].zones :
"${v}_${z_k}" => module.autoscale[v].zonal_instance_group_ids[z_k]
}
]...)
} | ||
|
||
autoscale = { | ||
fw-autoscale-common = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd propose to rename this deployment, so that it does not include "common" suffix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss this one during the planning.
Co-authored-by: michalbil <92343355+michalbil@users.noreply.github.com>
Co-authored-by: michalbil <92343355+michalbil@users.noreply.github.com>
Co-authored-by: michalbil <92343355+michalbil@users.noreply.github.com>
Co-authored-by: michalbil <92343355+michalbil@users.noreply.github.com>
Co-authored-by: michalbil <92343355+michalbil@users.noreply.github.com>
Co-authored-by: michalbil <92343355+michalbil@users.noreply.github.com>
Description
autoscale
examplevpc_peering_common_with_autoscale
metadata
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate)
Types of changes
Checklist