[Tokenizer] Enable padding_side as call time kwargs #9161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9161 +/- ##
===========================================
- Coverage 53.26% 53.26% -0.01%
===========================================
Files 652 652
Lines 105607 105618 +11
===========================================
+ Hits 56254 56257 +3
- Misses 49353 49361 +8 ☔ View full report in Codecov by Sentry. |
DrownFish19
reviewed
Sep 20, 2024
| @@ -3186,8 +3222,9 @@ def _pad( | |||
|
|
|||
| if needs_to_be_padded: | |||
| difference = max_length - len(required_input) | |||
| padding_side = padding_side if padding_side is not None else self.padding_side | |||
There was a problem hiding this comment.
最新调用方式看这里，self和传入参数二选一。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Description
Enable padding_side as call time kwargs.