Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fixes] fix TP_of_chatglm #8949

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

SevenSamon
Copy link
Contributor

PR types

Bug fixes

PR changes

Models

Description

  • The MLP.dense_h_to_4h segmentation of chatglmV1 is based on the default segmentation, resulting in the activation operation and the single card not aligned.
  • Customize the segmentation strategy function in _get_tensor_parallel_mappings

Copy link

paddle-bot bot commented Aug 16, 2024

Thanks for your contribution!

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 26 lines in your changes missing coverage. Please review.

Project coverage is 53.25%. Comparing base (e0d2809) to head (3b8f2ab).
Report is 114 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/chatglm/modeling.py 7.14% 26 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8949      +/-   ##
===========================================
- Coverage    54.79%   53.25%   -1.55%     
===========================================
  Files          636      652      +16     
  Lines        99876   105642    +5766     
===========================================
+ Hits         54732    56255    +1523     
- Misses       45144    49387    +4243     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZHUI
Copy link
Collaborator

ZHUI commented Sep 13, 2024

PR还需要吗?

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants