Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'withDeleted' #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ks-ocean
Copy link

use the 'strict' option for 'in_array'

http://php.net/manual/en/function.in-array.php

@tuna-rootnet
Copy link

Please merge this fix; I ran into this problem this week, tracked it down to in_array() not using strict mode. If your options contains something like ['some_key' => true], the plugin will not add the $aliasedField . 'IS NULL' to the query and include deleted records in the results, even though 'withDeleted' is not present in the array. Using strict for in_array resolves this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants