Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated frequency alias A with Y #1930

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Replace deprecated frequency alias A with Y #1930

merged 6 commits into from
Sep 20, 2024

Conversation

saschahofmann
Copy link
Contributor

Simply replaces the now deprecated annual frequency alias A with Y

@github-actions github-actions bot added the indicators Climate indices and indicators label Sep 19, 2024
Zeitsperre
Zeitsperre approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Zeitsperre Zeitsperre added the approved Approved for additional tests label Sep 20, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024 •
edited
Loading

Coverage Status

coverage: 89.374%. remained the same
when pulling 770d5c9 on saschahofmann:replace-A-period
into f7a76f0 on Ouranosinc:main.

@Zeitsperre
Copy link
Collaborator

@saschahofmann If you could simply add an entry in the changelog for this PR under Internal changes, we'll merge this ASAP. Thanks again!

@Zeitsperre Zeitsperre merged commit 1784307 into Ouranosinc:main Sep 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschahofmann @coveralls @Zeitsperre