Skip to content

Commit

Permalink
Relax test_adapt_freq error tolerance threshold (#1418)
Browse files Browse the repository at this point in the history
### What kind of change does this PR introduce?

* Relaxes the tolerance threshold so that false-positive errors occur
less often.

### Does this PR introduce a breaking change?

No.
  • Loading branch information
Zeitsperre committed Jul 25, 2023
1 parent 6d45217 commit 2323ba4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Internal changes
^^^^^^^^^^^^^^^^
* Tolerance thresholds for error in ``test_stats::test_fit`` have been relaxed to allow for more variation in the results. Previously untested ``*_moving_yearly_window`` functions are now tested. (:issue:`1400`, :pull:`1402`).
* Increased the guess of number of quantiles needed in ExtremeValues. ( :pull:`1413`).
* Tolerance thresholds for error in ``test_processing::test_adapt_freq`` have been relaxed to allow for more variation in the results. (:issue:`1417`, :pull:`1418`).

v0.44.0 (2023-06-23)
--------------------
Expand Down
2 changes: 1 addition & 1 deletion tests/test_sdba/test_processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def test_adapt_freq(use_dask):
)
# Assert that Pth and dP0 are approx the good values
np.testing.assert_allclose(pth, 20, rtol=0.05)
np.testing.assert_allclose(dP0, 0.5, atol=0.15)
np.testing.assert_allclose(dP0, 0.5, atol=0.25)
assert sim_ad.units == "mm d-1"
assert sim_ad.attrs["references"].startswith("Themeßl")
assert pth.units == "mm d-1"
Expand Down

0 comments on commit 2323ba4

Please sign in to comment.