Apply suggestions from aulemahal

Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>

xclim/indicators/atmos/_temperature.py

@@ -105,7 +105,7 @@ class Temp(Daily):
 class TempHourly(Indicator):
     """Temperature indicators involving hourly temperature."""
 
-    src_freq = "H"
+    src_freq = "h"
     keywords = "temperature"
 
 
@@ -1459,7 +1459,6 @@ def cfcheck(self, tas, snd=None):
     title="Chill portions",
     identifier="cp",
     units="",
-    standard_name="chill_portions",
     # TODO: check what this does
     cell_methods="",
     description="Chill portions are a measure to estimate the bud breaking potential of different crops. "
@@ -1484,8 +1483,6 @@ def cfcheck(self, tas, snd=None):
     description="Chill units are a measure to estimate the bud breaking potential of different crops based on the Utah model developed in "
     "Richardson et al. (1974). The Utah model assigns a weight to each hour depending on the temperature recognising that high temperatures can "
     "actually decrease the potential for bud breaking.",
-    # TODO: check what this does
-    standard_name="chill_units",
     long_name="Chill units after the Utah Model",
     allowed_periods=["A"],
     varname="cu",

xclim/indices/_agro.py

@@ -1594,7 +1594,8 @@ def chill_portions(tas: xarray.DataArray, freq: str = "YS") -> xarray.DataArray:
 
     Returns
     -------
-    xr.DataArray
+    xr.DataArray, [unitless]
+        Chill portions after the Dynamic Model
     """
     tas_K: xarray.DataArray = convert_units_to(tas, "K")
     return (
@@ -1637,7 +1638,5 @@ def chill_units(tas: xarray.DataArray, freq: str = "YS") -> xarray.DataArray:
                 ),
             ),
         )
-        .assign_attrs(units="")
-        .rename("cu")
     )
-    return cu.resample(time=freq).sum()
+    return cu.resample(time=freq).sum().assign_attrs(units="")

xclim/indices/helpers.py

@@ -655,7 +655,7 @@ def make_hourly_temperature(tasmin: xr.DataArray, tasmax: xr.DataArray) -> xr.Da
     with tasmin reached at sunsrise and tasmax reached 2h before sunset.
 
     For simplicity and because it's used for daily aggregation, we assume that sunrise globally happens at midnight
-    and the sunsets after `daylength` hours computed via the day_lengths function.
+    and the sunsets after `daylength` hours computed via the :py:func:`day_lengths` function.
 
     Parameters
     ----------