Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perses mapper #930

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Perses mapper #930

merged 8 commits into from
Sep 16, 2024

Conversation

jthorton
Copy link
Collaborator

@jthorton jthorton commented Sep 12, 2024

Replaces #929 to enable openeye tests

Checklist

  • Added a news entry

Developers certificate of origin

@IAlibay
Copy link
Member

IAlibay commented Sep 16, 2024

Not sure why codecov isn't picking up the extra test, let's see if bumping the PR helps.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (733908d) to head (78d67c9).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #930      +/-   ##
==========================================
- Coverage   94.32%   92.85%   -1.48%     
==========================================
  Files         134      134              
  Lines        9917     9931      +14     
==========================================
- Hits         9354     9221     -133     
- Misses        563      710     +147     
Flag Coverage Δ
fast-tests 92.85% <100.00%> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jthorton could you add a news entry please? (since it's technically changing behaviour from omm to off units). Otherwise it looks good to me!

P.S. macos failure is something else, issue has been raised upstream.

@jthorton
Copy link
Collaborator Author

thanks @IAlibay I have added it should it show in the docs build as part of the change log?

@IAlibay
Copy link
Member

IAlibay commented Sep 16, 2024

thanks @IAlibay I have added it should it show in the docs build as part of the change log?

I believe it will only show up when we call rever (we probably should fix that at some point?), so it should be good for now!

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@IAlibay IAlibay merged commit 117ce98 into main Sep 16, 2024
10 of 11 checks passed
@IAlibay IAlibay deleted the perses_mapper branch September 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants