-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perses mapper #930
Perses mapper #930
Conversation
Not sure why codecov isn't picking up the extra test, let's see if bumping the PR helps. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
==========================================
- Coverage 94.32% 92.85% -1.48%
==========================================
Files 134 134
Lines 9917 9931 +14
==========================================
- Hits 9354 9221 -133
- Misses 563 710 +147
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jthorton could you add a news
entry please? (since it's technically changing behaviour from omm to off units). Otherwise it looks good to me!
P.S. macos failure is something else, issue has been raised upstream.
thanks @IAlibay I have added it should it show in the docs build as part of the change log? |
I believe it will only show up when we call rever (we probably should fix that at some point?), so it should be good for now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Replaces #929 to enable openeye tests
Checklist
news
entryDevelopers certificate of origin