Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix installer #838

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix installer #838

merged 1 commit into from
Apr 19, 2024

Conversation

mikemhenry
Copy link
Contributor

Checklist

  • Added a news entry

Developers certificate of origin

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (3b76941) to head (98d9bd7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   94.13%   91.27%   -2.87%     
==========================================
  Files         134      134              
  Lines        9786     9786              
==========================================
- Hits         9212     8932     -280     
- Misses        574      854     +280     
Flag Coverage Δ
fast-tests 91.27% <ø> (?)
slow-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikemhenry
Copy link
Contributor Author

Okay installer didn't need any fixing!

@mikemhenry
Copy link
Contributor Author

@mikemhenry mikemhenry merged commit 378147c into main Apr 19, 2024
12 of 14 checks passed
@mikemhenry mikemhenry deleted the fix/improve_installer_building branch April 19, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant