OSW Weather emulator support #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+The OSW weather app is now supported also when using the emulator. +Documentation update
simonmicro
requested changes
Dec 17, 2023
| @@ -430,19 +483,21 @@ int OswAppWeather::getPrevDay() { | |||
|
|
|||
|
|
|||
| void OswAppWeather::setup() { | |||
| OSW_LOG_I("Setup "); | |||
There was a problem hiding this comment.
Could you cleanup these debug-prints? Or remove them from the release-build via OSW_LOG_D?
| @@ -6,15 +6,23 @@ OswAppWeatherEncoder::OswAppWeatherEncoder() {} | |||
| bool OswAppWeatherEncoder::setUpdate(OswAppWeather::weather_update_t update) { | |||
| bool update_ok = true; | |||
| if(update.temp > 99 || update.temp < -99 ) { | |||
| update_ok = false; | |||
| OSW_LOG_I("ERROR TEMP"); | |||
There was a problem hiding this comment.
(or OSW_LOG_W if you can still continue with the primary function)
Cleanup debug print
Error print
Warnings
Errors and warnings
Warnings
|
Hmmm, this is still a draft... |
simonmicro
added
⭐ enhancement
RuffaloLavoisier
requested review from
RuffaloLavoisier
and removed request for
RuffaloLavoisier
Merged
|
I'll cleanup and finalize this PR in #382, as the author did not authorize modifications on its fork before merge. As I cannot change this PRs source, I'll close it instead. |
simonmicro
added a commit
that referenced
this pull request
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to enable emulator support in the application OSW Weather. The key enhancement is the ability of the emulator to load a JSON file containing a valid API response from OpenWeather.
Changes:
Added emulator support to OSW Weather
Documentation update