-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing/integration tests #367
Testing/integration tests #367
Conversation
Fix errors in Emulator.cpp, because some files in ImGUI were renamed from "sdl" to "sdl2" Update is necessary for compatibility with ImGUI Test Engine
Because I plan to add UI Tests
Add UI tests for alarm and timer
Fix all errors related to merge
11a8daf
to
b60e8b0
Compare
Hi,
After you put so much work into it to re-submit this PR I'll absolutely make sure to get it merged this time. This is the next thing going in - so I'll not allow this to run out-of-sync again! Hehe... P.S. There is so much code, I'll try to dive deeper into it at a later date - for now I also have too much of my own work going on... |
Fixed (hopefully) by pushing ImGui Test Engine submodule folder
Done. I forgot about this one :) p.s: in my last PR it wasn't your fault, we were playing with rebases and the situation got out of hand :) Old commits were rebased and git thought they were new commits, because their hash was different. At least I think that's what happened... Anyway, it was too painful to fix... |
Ok, I also removed It turned out, that |
@akmal-threepointsix If you formulate that like this... Ever thought about the more safe variant of https://en.cppreference.com/w/cpp/language/dynamic_cast ? This also ensures you won't cast in the future if we break it 😉 |
Yes, sure, |
Ok, done. Changed |
Since this old PR #351 diverged too much from the up-to-date develop branch, I decided to create a new branch from the develop and open this new PR.
These changes are basically the same as in PR #351:
CMakeLists.txt
,emulator/lib/ImGUI_TestEngine
). IMPORTANT: since I added new submodule, you need to run$ git submodule update --init --recursive
after checkout to this branchemulator/lib/ImGUI
)emulator/src/UiTests/OswAppAlarm.cpp
,emulator/src/UiTests/OswAppTimer.cpp
)README.md
with new testing chapteremulator/include/Emulator.hpp
,include/apps/OswAppDrawer.h
andinclude/apps/OswAppV2Compat.h
)And some NEW changes:
UiTest_main.hpp
, I added some code to skip tutorial, if emulator was launched with--ui_tests
option