-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDX-9931 - deploy ckan locally using devcontainers #6391
Draft
IanHopkinson
wants to merge
17
commits into
dev
Choose a base branch
from
feature/HDX-9931_deploy_locally
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+301
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build #5535Details
💛 - Coveralls |
teodorescuserban
requested changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think you need to remove all .js and .css files committed.
- The aws cli v2 installation might be perhaps better added in the Dockerfile , so you have it included already
- Please remember than the hdxckantool is used on the shared infrastructure environments and needs to be able to operate correctly with both local development (where ckan can be the superuser and can remove and create databases) as well as on AWS RDS (where there is no readily available access at superuser) - I will need more time to review the hdxckantool changes
- ending ith an empty new line is highly encouraged (even by gihub ui).
@teodorescuserban to install
|
alexandru-m-g
requested changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes required to deploy ckan locally into devcontainers for use with VS Code, developed on a Windows 11 machine.
The main action is in improving documentation in
.devcontainer/README.md
with some changes to thedocker/hdxckantool-ng.py
which implements thehdxckantool
. There is a script to install theawscli
in.devcontainer
which is nasty (curls a file, unzips it and then installs, and my shell skills are limited) but as recommended by AWS.pip install awscli
installs the old V1 CLI which is no longer recommended.A bunch of JavaScript files appeared during installation, so I committed them. And there is a
less
folder which I deleted because at one point I thought it was blocking installation.The
devcontainer/README.md
should get a developer to a point where they can run tests, and also deploy a slightly sluggish copy of the HDX Website. Reducing the docker mem_limit for the containers from 16GB each to 4GB each greatly reduced page render times (from ~2 minutes per page to 15 seconds). Possibly reducing mem_limit to 2GB will provide further improvement.I can't add a login to HDX because recaptcha does not work on localhost.
The VS Code test runner fails during discovery, I think because the repo pins an older version of pytest/pluggy.
microsoft/vscode-python#23707
Next steps:
hdxckantool-ng.py
;This PR is provided for discussion and review. I think it needs some improvement.