Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add directive to render the tooltip #27 #28

Merged
merged 35 commits into from
Sep 2, 2023

Conversation

NsdHSO
Copy link
Owner

@NsdHSO NsdHSO commented Aug 31, 2023

What type of PR is this? (check all applicable)

  • ♻️ Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 👷 Optimization
  • 📝 Documentation Update
  • 🔖 Release
  • 🚩 Other

Description

In this PR I added a directive and a tooltip wrapper that can embed a template container a component etc. This directive can be managed without us where is the tooltip side where will be placeble.

This PR [adds/removes/fixes/replaces] this [feature/bug/etc].

Related Tickets & Documents

Closes #27

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 readme
  • 📜 contributing.md
  • 📓 docs
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coagulu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2023 10:00am

@NsdHSO NsdHSO added this to the Generate Input milestone Aug 31, 2023
@NsdHSO NsdHSO added the enhancement New feature or request label Aug 31, 2023
@NsdHSO NsdHSO self-assigned this Aug 31, 2023
Repository owner deleted a comment from netlify bot Sep 1, 2023
@NsdHSO NsdHSO merged commit 30c5f89 into master Sep 2, 2023
5 checks passed
@NsdHSO NsdHSO deleted the directive-to-render-the-tooltip-27 branch September 2, 2023 10:00
@sonarcloud
Copy link

sonarcloud bot commented Sep 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

0.0% 0.0% Coverage
2.2% 2.2% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

feat: directive to render the tooltip
1 participant