Yaml tables for ensembles and nests #1585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… diag_table.ensXX.yaml files are present
bensonr
requested changes
Sep 6, 2024
| @@ -591,9 +591,18 @@ subroutine read_table_yaml(data_table) | |||
| integer :: nentries, mentries | |||
| integer :: i | |||
| character(len=50) :: buffer | |||
| character(len=255) :: filename !< Name of the expected data_table.yaml | |||
There was a problem hiding this comment.
This should use the filename length macro in platform.F90
diag_manager/fms_diag_yaml.F90
Outdated
| @@ -381,10 +382,17 @@ subroutine diag_yaml_object_init(diag_subset_output) | |||
| !! outputing data at every frequency) | |||
| character(len=:), allocatable :: filename!< Diag file name (for error messages) | |||
| logical :: is_instantaneous !< .True. if the file is instantaneous (i.e no averaging) | |||
| character(len=255) :: yamlfilename !< Name of the expected diag_table.yaml | |||
There was a problem hiding this comment.
This should use the filename length macro in platform.F90
field_manager/field_manager.F90
Outdated
Comment on lines
609
to
610
| character(len=255) :: filename !< Name of the expected field_table.yaml | ||
|
|
uramirez8707
requested review from
thomas-robinson and
rem1776
as code owners
bensonr
previously approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability for each ensemble/nest to have its own diag/field/data yaml tables.
This will allow users to specify a unique forcing file for each ensemble member (Fixes #1568) and to specify a different file frequency for multiple grids (Fixes #1573)
For example, for a run with 2 ensemble members, fms will search for diag_table_ens_01.yaml and diag_table_ens_02.yaml.
Similarly, for a run with a nest, fms will search for diag_table.yaml (for the parent grid) and diag_table_nest_01.yaml (for the nest grid),
nest_01can be whatever is passed in to fms via theset_filename_appendixcall.Fixes # (issue)
How Has This Been Tested?
CI including new tests
Checklist:
make distcheckpasses