Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding null course units information check #1332

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Sep 16, 2024

Closes #[issue number]
[Description of the changes proposed in the pull request. Include steps to replicate the behavior and screenshots if UI is updated]

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 11%. Comparing base (fc9e349) to head (5bc73f9).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1332   +/-   ##
=======================================
+ Coverage       11%     11%   +1%     
=======================================
  Files          268     268           
  Lines         7310    7330   +20     
=======================================
+ Hits           799     802    +3     
- Misses        6511    6528   +17     

packages/uni_app/lib/l10n/intl_en.arb Outdated Show resolved Hide resolved
@limwa
Copy link
Member

limwa commented Sep 16, 2024

LGTM 🚀

@limwa limwa merged commit 00fc389 into develop Sep 16, 2024
6 checks passed
@limwa limwa deleted the fix/course-unit-null-info branch September 16, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants