fix(converter): Update output after conversion

Myzel394 · May 2, 2024 · c606328 · c606328
1 parent 1af4e97
commit c606328
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/data/converter/src/main/java/app/myzel394/numberhub/data/converter/UnitsRepositoryImpl.kt b/data/converter/src/main/java/app/myzel394/numberhub/data/converter/UnitsRepositoryImpl.kt
@@ -342,7 +342,9 @@ class UnitsRepositoryImpl @Inject constructor(
             val conversion = unitFrom.convert(unitTo, value)
 
             ConverterResult.NumberBase(conversion)
-        } catch (e: Exception) {
+        } catch (error: Exception) {
+            Log.e("UnitsRepositoryImpl", "Failed to convert number base $unitFromId -> $unitToId: $error")
+            error.printStackTrace()
             ConverterResult.Error.ConversionError
         }
     }

diff --git a/...re/converter/src/main/java/app/myzel394/numberhub/feature/converter/ConverterViewModel.kt b/...re/converter/src/main/java/app/myzel394/numberhub/feature/converter/ConverterViewModel.kt
@@ -23,6 +23,7 @@ import androidx.lifecycle.SavedStateHandle
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
 import app.myzel394.numberhub.core.base.OutputFormat
+import app.myzel394.numberhub.core.base.Token
 import app.myzel394.numberhub.core.ui.common.textfield.getTextField
 import app.myzel394.numberhub.data.common.combine
 import app.myzel394.numberhub.data.common.stateIn
@@ -175,11 +176,13 @@ internal class ConverterViewModel @Inject constructor(
     fun convertNumberBase() {
         conversionJob?.cancel()
         conversionJob = viewModelScope.launch {
-            unitsRepo.convertNumberBase(
+            val result = unitsRepo.convertNumberBase(
                 unitFromId = unitFromId.value ?: return@launch,
                 unitToId = unitToId.value ?: return@launch,
-                value = input1.value.text,
+                value = input1.value.text.ifEmpty { Token.Digit._0 }
             )
+
+            output.update { result }
         }
     }