Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio: validate contact form #13

Merged
merged 11 commits into from
Jun 29, 2023
Merged

Portfolio: validate contact form #13

merged 11 commits into from
Jun 29, 2023

Conversation

MozamelJawad
Copy link
Owner

In this part, I implemented the following validation rules:

  • The content of the email field accepts letters in lowercase.
  • When the user submits the form, it is checked that the email is in lowercase.
  • If the validation is OK, the form is sent.
  • If the validation is not OK, the form is not sent, and an error message shows to the user near the submit button informing them of the error.

Copy link

@wayungi wayungi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MozamelJawad ,

image

Great work, your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Remember: Every finish line 🏁 is the beginning of a new race 🐎

Highlights

  • Profesional README ✔️
  • All linter checks passing ✔️
  • Email validation works great ✔️
  • Wrong email error is displayed with good contrast around submit button ✔️
  • The submit event is used to trigger form validation ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@MozamelJawad MozamelJawad merged commit 949260d into main Jun 29, 2023
5 checks passed
@MozamelJawad MozamelJawad deleted the cantact-validation branch June 29, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants