-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating behaviour of VaultsSecretsGet
to align with requirements of secrets cat
#805
base: staging
Are you sure you want to change the base?
Conversation
I have implemented basic functionality for displaying file contents for multiple files, and updated the tests in I still need to review the issue spec and all the code to ensure everything's ready for review. |
MatrixAI/Polykey-CLI#243 (comment) I'm going to go ahead with the assumption that we need to implement support for listing contents for files from multiple vaults concurrently, as that makes sense and retains consistency with UNIX commands and I will wait for review of my approach from |
69e9b36
to
e44a713
Compare
The naming of secret commands has changed from what it was. The intention was to keep using the pattern of We are kinda moving away from the pattern. This was hard to detect as this change was made one-at-a-time across multiple PRs. We might need to look into this and set a standard pattern to follow for ensuring consistency. |
af985a8
to
d777f92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes, just check your tests are only testing the specific condition we want.
0f3b850
to
a1623a4
Compare
feat: concatenates secrets from multiple vaults feat: updated RPC handlers taking multiple secret paths to use duplex streams chore: updated tests chore: updated metadata assignment
a1623a4
to
2ffd590
Compare
Description
The current
VaultsSecretsGet
only gets a single secret from the vault, and returns it in the form of aUnaryHandler
, meaning for large files, the RPC call will timeout. It also fetches only one file at a time, so behaviour like UNIX'scat
command isn't possible.This PR aims to fix that issue by switching over the RPC handler to a
ServerHandler
, supporting larger files. This PR also adds support for listing the contents of multiple files in order, like whatcat
does.Issues Fixed
secrets cat
command Polykey-CLI#243Tasks
UnaryHandler
toStreamHandler
Final checklist