Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing file system pattern walker #769

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Implementing file system pattern walker #769

merged 3 commits into from
Jul 17, 2024

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Jul 11, 2024 •
edited
Loading

Description

This PR adds a walker utility for generating a list of directories, files, and their contents from a file pattern

Issues Fixed

Fixes #767
Fixes ENG-363

Tasks

  • 1. Implement the globing file tree walker.
  • 2. Include options for optionally yielding certain details such as files, directories, parent directories, file contents and stats. We won't need all this information all the time.
  • 2. Add tests for demonstrating usage.
  • 3. Add tests for efs and fs cross compatibility.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Jul 11, 2024
@linear Linear
Copy link

linear bot commented Jul 11, 2024

ENG-363 Implement utility that generates a file tree from a path pattern

@tegefaulkes tegefaulkes changed the title wip: getting started Implementing file system pattern walker Jul 11, 2024
@tegefaulkes tegefaulkes mentioned this pull request Jul 12, 2024
Closed
@tegefaulkes tegefaulkes force-pushed the feature-eng-363-implement-utility-that-generates-a-file-tree-from-a-path branch from 31a3d02 to 5fda51c Compare July 16, 2024 01:58
@tegefaulkes tegefaulkes force-pushed the feature-eng-363-implement-utility-that-generates-a-file-tree-from-a-path branch from 5fda51c to 884262c Compare July 16, 2024 02:07
@tegefaulkes tegefaulkes force-pushed the feature-eng-363-implement-utility-that-generates-a-file-tree-from-a-path branch from 884262c to 48b78af Compare July 16, 2024 02:33
@tegefaulkes tegefaulkes marked this pull request as ready for review July 16, 2024 02:55
@tegefaulkes
fix: removed yieldContents feature
1496d2c 
It's not optimal to hold the whole file in memory like that. The file contents will need to be streamed when needed.

[ci skip]
@tegefaulkes tegefaulkes force-pushed the feature-eng-363-implement-utility-that-generates-a-file-tree-from-a-path branch from 150ee5e to 1496d2c Compare July 17, 2024 04:01
@tegefaulkes tegefaulkes merged commit 2a88416 into staging Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tegefaulkes tegefaulkes

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement utility that generates a file tree from a path pattern
1 participant
@tegefaulkes