Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swapping to SWC, Updating to M1 MacOS, and updating dependencies #529

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

CMCDragonkai
Copy link
Member

@CMCDragonkai CMCDragonkai commented Jul 4, 2023

Description

This PR is for switching to using @swc/jest.

I think this was a dangling branch, but has a change that we want to make use of now that everything is now using swc.

However there are some things in this change that still need testing like the removal of jose and babel-jest.

Issues Fixed

Tasks

  • 1. Update all MatrixAI dependencies to the latest that has been released
  • 2. Test swc tests work
  • 3. Remove or simplify tests that are not required

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@CMCDragonkai
Copy link
Member Author

@tegefaulkes this should be merged first... after completing the tasks.

@ghost
Copy link

ghost commented Jul 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@CMCDragonkai CMCDragonkai changed the title test: swap from ts-jest and babel-jest for @swc/jest Swapping to SWC, Updating to M1 MacOS, and updating dependencies Jul 4, 2023
@CMCDragonkai
Copy link
Member Author

The SWC may still have some weird decorator problem but we don't actually use it, so if we have a test for that, we can just disable for those.

This PR can be used to sort out #528 too.

Although atm due to problems compiling js-quic on Windows, we may have some problems releasing a build for Windows.

At any case we will focus on just Linux for now.

@CMCDragonkai
Copy link
Member Author

@tegefaulkes focus on this one first. Get the SWC into it, and update all relevant dependencies before js-quic. Then merge this into staging.

Then in #525, you can rebase that on top of this and bring in the 0.0.10 js-quic and start integrating that.

We will then address #268 and move all the of the CLI related things to Polykey-CLI so we can get the CI/CD to pass here since the pkg has problems building with the latest nodejs and we can focus in on packing and bundling in Polykey-CLI.

- Also updated `systeminformation` to `^5.18.5`

[ci skip]
@tegefaulkes
Copy link
Contributor

I'm going to leave updating dependencies to later. They include breaking API changes and I'd rather have fixes included in the the commit. But at the same time I don't want to re-base on top of any fixes that need to be done.

@CMCDragonkai
Copy link
Member Author

The only breaking change should be the js-db and js-async-locks when it comes to timeouts...

@CMCDragonkai
Copy link
Member Author

Also this will break the CI build due to MatrixAI/TypeScript-Demo-Lib#94 (comment).

We have to accept the breaking for now until all CLI stuff moves to Polykey-CLI.

- async-cancellable: ^1.0.6 -> ^1.1.1
- async-init: ^1.8.2 -> ^1.8.4
- async-locks: ^3.2.0 -> ^4.0.0
- contexts: ^1.0.0 -> ^1.1.0
- db: ^5.1.0 -> ^5.2.0
- id: ^3.3.3 -> ^3.3.6
- resources: ^1.1.4 -> ^1.1.5
- timer: ^1.1.0 -> ^1.1.1
- workers: ^1.3.7 -> ^1.3.6

[ci skip]
@tegefaulkes
Copy link
Contributor

I can't fully tests things are working since the state of the staging branch is between the client and agent migration. I'll have to do any testing and fixes in the agent migration branch after rebasing it on top of this.

@CMCDragonkai
Copy link
Member Author

Yes that's fine, it just has to be merged to staging, you should do some sanity check though.

@tegefaulkes
Copy link
Contributor

Alright, I'm merging this now. given the incomplete state of staging I can't run any tests to fully check if all the changes work. That will be done in #525 after rebasing it.

@tegefaulkes tegefaulkes merged commit e34fcd6 into staging Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update MacOS GitLab CI/CD configuration by 31st May
2 participants