-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing vault sharing and the restrictions of pulling and cloning with vault permissions #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the this binding
…m `@matrixai/js-async-init`
…atadir deletion and db destroy
scottmmorris
force-pushed
the
vaultspermissions
branch
from
October 25, 2021 08:21
7f285ac
to
9e0cd03
Compare
CMCDragonkai
force-pushed
the
vaultsrefactoring
branch
from
October 25, 2021 11:32
50183f7
to
1a9173e
Compare
Please add in the lintfixing related to vaults work: https://gitlab.com/MatrixAI/Engineering/Polykey/js-polykey/-/merge_requests/205/#note_712956648 |
I have to recreate this PR because I deleted the base branch :(. |
Recreated here #262. |
43 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to allow vaults to be shared and unshared with other node Ids. In other words the ability to overwrite (either set or unset) the vault permissions and have the agent check that the permissions for a node are valid for the clone or pull action that is being performed.
Issues Fixed
shareVault
/unshareVault
implementation #259Tasks
agentService
Final checklist