Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing vault sharing and the restrictions of pulling and cloning with vault permissions #262

Closed
wants to merge 124 commits into from

Conversation

scottmmorris
Copy link
Contributor

Description

This pull request aims to allow vaults to be shared and unshared with other node Ids. In other words the ability to overwrite (either set or unset) the vault permissions and have the agent check that the permissions for a node are valid for the clone or pull action that is being performed.

Issues Fixed

Tasks

  1. Complete the share and unshare vault functions
    • Set the gestalt action for the node
    • Set the vault action for both pull and clone
    • Send a notification to the node (only for sharing)
  2. Check the ACL for vault permissions in agentService
    • Send node Id and vault action metadata over GRPC
    • Access the relevant vault and node permissions in the ACL
    • Copmare the permissions and throw if not valid
  3. Expand testing for vault sharing

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@scottmmorris scottmmorris self-assigned this Oct 25, 2021
@scottmmorris scottmmorris changed the base branch from master to vaultsrefactoring October 25, 2021 08:10
@CMCDragonkai
Copy link
Member

Please add in the lintfixing related to vaults work: https://gitlab.com/MatrixAI/Engineering/Polykey/js-polykey/-/merge_requests/205/#note_712956648

@CMCDragonkai CMCDragonkai deleted the branch vaultsrefactoring October 25, 2021 13:03
@CMCDragonkai
Copy link
Member

I have to recreate this PR because I deleted the base branch :(.

@CMCDragonkai
Copy link
Member

Recreated here #262.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Complete shareVault/unshareVault implementation
4 participants