Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added python setup info + building wheels locally + GH Action. #223

Merged
merged 36 commits into from
Sep 4, 2024

Conversation

Martinsos
Copy link
Owner

@Martinsos Martinsos commented Sep 2, 2024

TODO:

  • Get Github Action to work.
  • Migrate to Github Actions from Travis CI.
  • Try getting wheel building to run locally also and if so, use that command also in CI.
  • I am currently using Makefile for python stuff, but I should probably instead be using setup.py and/or pyproject.toml. I should look into that, if I can get rid of Makefile, then other stuff might also work smoother. And then also I can somewhere properly declare which are the deps that python binding uses (for dev), instead of installing one by one in the makefile? Not sure.
  • Migrate to Github Actions from Appveryor (for win).
  • Make sure to hunt down all the TODOs I introduced in this PR and handle them.

@Martinsos Martinsos mentioned this pull request Sep 3, 2024
@Martinsos
Copy link
Owner Author

Got wheels building! Not for macos14, nor for windows, but we also didn't have that before, and now they are building for python 3.12 which is great.

@Martinsos
Copy link
Owner Author

Works, merging!

@Martinsos Martinsos merged commit b237b5f into master Sep 4, 2024
8 of 10 checks passed
@Martinsos Martinsos deleted the python-wheels-and-ga branch September 4, 2024 22:55
Martinsos added a commit that referenced this pull request Sep 4, 2024
published 1.3.9.post1 . (#223)

* Added python setup info + building wheels locally + GH Action.

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* Got it working, but I am producing wheels only for glibc 2.28 and no musl.

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* done

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant