Translations and polish for unlimited points #1665
Open
+63
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2024 16:45
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: +72 B (+0.01%) Total Size: 863 kB
ℹ️ View Unchanged
|
benchristel
reviewed
Sep 24, 2024
| @@ -74,7 +74,8 @@ export function interactiveGraphReducer( | |||
| ): InteractiveGraphState { | |||
| switch (action.type) { | |||
| case REINITIALIZE: | |||
| return initializeGraphState(action.params); | |||
| return state; | |||
| // return initializeGraphState(action.params); | |||
There was a problem hiding this comment.
Pretty sure this change shouldn't be here, right?
| @@ -358,13 +368,19 @@ const renderGraphControls = (props: { | |||
| state: InteractiveGraphState; | |||
| dispatch: (action: InteractiveGraphAction) => unknown; | |||
| width: number; | |||
| strings: PerseusStrings; | |||
There was a problem hiding this comment.
Instead of adding a prop for the strings, could we call usePerseusI18n here too? Or is that not possible / advisable? It seems like using the context might be a bit more convenient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: https://khanacademy.atlassian.net/browse/LEMS-1670
Test plan: