-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove onInputError #1661
Remove onInputError #1661
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: -362 B (-0.04%) Total Size: 862 kB
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (81a4c9d) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1661 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1661 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1661 +/- ##
==========================================
- Coverage 70.71% 70.19% -0.52%
==========================================
Files 560 586 +26
Lines 107921 112375 +4454
Branches 5320 11333 +6013
==========================================
+ Hits 76317 78887 +2570
- Misses 31483 33488 +2005
+ Partials 121 0 -121 see 1146 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, so we just don't need it at all! Cool!
Summary:
I didn't see that it was actually being used except in the protowebapp repo...which is obviously legacy.
Issue: LEMS-2422
Test plan:
Nothing should functionally change