Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onInputError #1661

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Remove onInputError #1661

merged 2 commits into from
Sep 24, 2024

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Sep 24, 2024

Summary:

I didn't see that it was actually being used except in the protowebapp repo...which is obviously legacy.

Issue: LEMS-2422

Test plan:

Nothing should functionally change

@handeyeco handeyeco self-assigned this Sep 24, 2024
@handeyeco handeyeco changed the title remove onInputError Remove onInputError Sep 24, 2024
@khan-actions-bot khan-actions-bot requested a review from a team September 24, 2024 15:03
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Sep 24, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/tough-snails-double.md, packages/perseus/src/perseus-api.tsx, packages/perseus/src/renderer.tsx, packages/perseus/src/types.ts, packages/perseus-editor/src/iframe-content-renderer.tsx, packages/perseus/src/__tests__/renderer-api.test.tsx, packages/perseus/src/widgets/expression/expression-validator.test.ts, packages/perseus/src/widgets/expression/expression-validator.ts, packages/perseus/src/widgets/expression/expression.tsx, packages/perseus/src/widgets/expression/expression.types.ts, packages/perseus/src/widgets/input-number/input-number-validator.ts, packages/perseus/src/widgets/input-number/input-number.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Size Change: -362 B (-0.04%)

Total Size: 862 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 278 kB -9 B (0%)
packages/perseus/dist/es/index.js 418 kB -353 B (-0.08%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.36 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Sep 24, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (81a4c9d) and published it to npm. You
can install it using the tag PR1661.

Example:

yarn add @khanacademy/perseus@PR1661

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1661

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.19%. Comparing base (c04d275) to head (81a4c9d).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1661      +/-   ##
==========================================
- Coverage   70.71%   70.19%   -0.52%     
==========================================
  Files         560      586      +26     
  Lines      107921   112375    +4454     
  Branches     5320    11333    +6013     
==========================================
+ Hits        76317    78887    +2570     
- Misses      31483    33488    +2005     
+ Partials      121        0     -121     

Impacted file tree graph

see 1146 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c04d275...81a4c9d. Read the comment docs.

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

Copy link
Collaborator

@jeremywiebe jeremywiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, so we just don't need it at all! Cool!

@handeyeco handeyeco merged commit 391641a into main Sep 24, 2024
12 of 13 checks passed
@handeyeco handeyeco deleted the LEMS-2422/on-input-error branch September 24, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants