[Locked Figure Labels] Add/edit/delete locked ellipse labels #1655
+293
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sually different on initial load
- Add feature flag for locked ellipse labels - Add labels to LockedEllipseType - Update builder - Update stories and tests Issue: https://khanacademy.atlassian.net/browse/LEMS-2349 Test plan: - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-ellipse-labels-flag - Confirm that the visible label is on the locked ellipse only - Go to the point, line, and vector stories and confirm that the locked ellipse does not have a visible label (make sure the flags are separating the behaviors correctly)
… this more complex than it needs to be
Add the ability to add/edit/delete labels for locked ellipses within the interactive graph editor. Issue: https://khanacademy.atlassian.net/browse/LEMS-2349 Test plan: - Go to http://localhost:6006/?path=/story/perseuseditor-widgets-interactive-graph--mafs-with-locked-ellipse-labels-flag - Go to locked figures - Open the locked ellipse settings - Confirm that the label settings are there - Play around with the label settings and confirm that it moves and updates with the ellipse
nishasy
requested review from
benchristel,
catandthemachines,
anakaren-rojas and
a team
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (505b4ae) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1655If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1655 |
|
Size Change: +112 B (+0.01%) Total Size: 863 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
==========================================
+ Coverage 70.45% 70.63% +0.18%
==========================================
Files 562 588 +26
Lines 108077 112705 +4628
Branches 7944 11428 +3484
==========================================
+ Hits 76142 79607 +3465
- Misses 31748 33098 +1350
+ Partials 187 0 -187 see 1150 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
catandthemachines
approved these changes
Sep 20, 2024
|
The parent pull-request (#1653) has been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add the ability to add/edit/delete labels for locked ellipses
within the interactive graph editor.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2349
Test plan:
and updates with the ellipse