Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Locked Figure Labels] Add/edit/delete locked vector labels #1652

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

nishasy
Copy link
Contributor

@nishasy nishasy commented Sep 19, 2024

Summary:

Add the ability to add/edit/delete labels for locked vectors
within the interactive graph editor.

Issue: https://khanacademy.atlassian.net/browse/LEMS-2348

Test plan:

image

Copy link
Contributor

github-actions bot commented Sep 19, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (09ae084) and published it to npm. You
can install it using the tag PR1652.

Example:

yarn add @khanacademy/perseus@PR1652

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1652

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Size Change: +138 B (+0.02%)

Total Size: 863 kB

Filename Size Change
packages/perseus-editor/dist/es/index.js 279 kB +138 B (+0.05%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.3 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 418 kB
packages/perseus/dist/es/strings.js 3.36 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@nishasy nishasy marked this pull request as ready for review September 19, 2024 18:47
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Sep 19, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/modern-sheep-bathe.md, packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-vector-settings.test.tsx, packages/perseus-editor/src/widgets/interactive-graph-editor/locked-figures/locked-vector-settings.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.89%. Comparing base (03cddb6) to head (09ae084).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
+ Coverage   70.71%   70.89%   +0.17%     
==========================================
  Files         562      588      +26     
  Lines      107953   112587    +4634     
  Branches     7955    12031    +4076     
==========================================
+ Hits        76336    79814    +3478     
- Misses      31495    32773    +1278     
+ Partials      122        0     -122     

Impacted file tree graph

see 1150 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cddb6...09ae084. Read the comment docs.

Copy link
Member

@benchristel benchristel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nishasy nishasy changed the base branch from locked-vector-labels to main September 24, 2024 16:52
@nishasy nishasy merged commit 1ed0455 into main Sep 24, 2024
13 checks passed
@nishasy nishasy deleted the locked-vector-labels-editor branch September 24, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants