Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI/#18] search / 검색 뷰 구현 #31

Merged
merged 22 commits into from
Jun 27, 2023
Merged

[UI/#18] search / 검색 뷰 구현 #31

merged 22 commits into from
Jun 27, 2023

Conversation

0zlrlo
Copy link
Member

@0zlrlo 0zlrlo commented May 22, 2023

관련 이슈

작업 내역

  • listadapter 사용
  • debounce 사용

PR 포인트

  • 앞으로는 시험 준비로 인해서 신경을 못 쓸 거 같아 검색뷰 까지 후딱 해서 올립니다ㅠㅠ
  • '검색결과 %s개' flow에서 '%s'와 '검색결과' '개' 의 폰트가 다릅니다! 이 부분 코드에 손을 많이 댔는데 원하는대로 해결이 안되어 조언을 구하고자 올립니다.
  • 실행결과는 노션 페이지의 '검색 뷰 pr'을 봐주시면 됩니다.

실행 화면

https://www.notion.so/c6f9c63a7e6b440c9c044cd5d5932bd8

0zlrlo added 18 commits May 3, 2023 17:49
@0zlrlo
[MOD/#18] 컬러 네임 수정
2e07209
@0zlrlo
[UI/#18] 전반적인 검색 뷰 완성
1262699
@0zlrlo
[MOD/#18] 리사이클러뷰 dp값 조정
3d40e1c
@0zlrlo
[ADD/#18] drawable 파일 추가
c4cdf71
@0zlrlo
[MOD/#18] 전체적으로 dp값 수정 완료
9f50955
@0zlrlo
[MOD/#18] 충돌 해결
676bcd8
@0zlrlo
[MOD/#18] 충돌 해결
d71774a
@0zlrlo
[MOD/#18] 검색 뷰 ui 수정
b60c016
@0zlrlo
[MOD/#18] shape 수정
fc9ca7a
@0zlrlo
[MOD/#18] 탐색 뷰 category selector 수정
49c4f15
@0zlrlo
[ADD/#18] 카테고리 검색할 수 있게끔 기초 세팅
3ffe361
@0zlrlo
[ADD/#18] viewmodel 세팅
105dc29
@0zlrlo
[ADD/#18] adapter 세팅
3fe6e9e
@0zlrlo
[ADD/#18] contentDescription 추가
4ffbc9a
@0zlrlo
[FEAT/#18] debounce 코루틴 구현
fa90ce5
@0zlrlo
[MOD/#18] 검색버튼 누를 때 리사이클러뷰 뜨게끔
efb3885
@0zlrlo
[ADD/#18] 아이템 갯수 세기 관련 코드 추가
6b303f8
@0zlrlo
[MOD/#18] 린트 수정 및 아이템갯수세는 코드 삭제
04e6cfa
@0zlrlo 0zlrlo added PULL REQUEST 🚀 pull request 날리기 UI 💐 UI 작업 지은 🐭 지은's task labels May 22, 2023
@0zlrlo 0zlrlo added this to the 베타 서비스 개발 milestone May 22, 2023
@0zlrlo 0zlrlo requested review from b1urrrr and etama123 May 22, 2023 11:41
@0zlrlo 0zlrlo self-assigned this May 22, 2023
etama123
etama123 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@etama123 etama123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM💖
항상 빠르게 맡은 바를 다하는 모습이 정말 멋집니다!

app/src/main/res/values/strings.xml
@@ -14,13 +14,18 @@

<!-- search -->
<string name="search_content">제목, 키워드</string>
<string name="search_cancel">취소</string>
<string name="search_result">검색결과</string>
<string name="search_count">%s개</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문자열 포맷이라서 글꼴이 적용안되는 게 아닐까요?
혹시 들어갈 내용이 있어도 글꼴 적용이 안되나요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 아 아니요! 원래는 두 개를 flow로 연결했는데 이번엔 3개(폰트 다름 이슈로)를 연결해야 할 거 같더라구요 근데 잘 안돼서 여쭤봤습니다!

b1urrrr
b1urrrr approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@b1urrrr b1urrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰가 늦어서 죄송합니다 🥲
고생 많으셨어요 👍👍

app/src/main/java/com/release/keyneez/presentation/main/search/SearchActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/com/release/keyneez/presentation/main/search/SearchActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/com/release/keyneez/presentation/main/search/SearchActivity.kt Outdated Show resolved Hide resolved
app/src/main/java/com/release/keyneez/presentation/main/search/SearchAdapter.kt Outdated Show resolved Hide resolved
@0zlrlo 0zlrlo merged commit d5493f4 into develop Jun 27, 2023
1 check passed
@b1urrrr b1urrrr deleted the feature/#18-ui-search-view branch July 8, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1urrrr b1urrrr b1urrrr approved these changes

@etama123 etama123 etama123 approved these changes

Assignees

@0zlrlo 0zlrlo

Labels
PULL REQUEST 🚀 pull request 날리기 UI 💐 UI 작업 지은 🐭 지은's task
Projects
Keyneez Android 💚
Status: Done
Milestone
베타 서비스 개발
Development

Successfully merging this pull request may close these issues.

[UI] search / 검색 뷰 구현
3 participants
@0zlrlo @b1urrrr @etama123