Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency gem versions #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dilumn
Copy link

@dilumn dilumn commented Nov 30, 2019

TE still have alipay-global & alipay integration code base even though we don't use Alipay directly anymore. alipay-global is using an old version of rest-client with mime-types < 3.0

Because of mime-types version conflict we couldn't update httparty gem to the latest.

So @melvrickgoh @arnvald it would be great if you can merge this rest-client update to master & release 0.0.7 to rubygems

And also I found out fakeweb gem is not supporting from Ruby 2.4 onwards - chrisk/fakeweb#57 & added fakeweb-fi as the fix. And fixed some failing tests

@juny4ng
Copy link

juny4ng commented Nov 30, 2019

Maybe we should start removing the alipay code instead?

@dilumn
Copy link
Author

dilumn commented Nov 30, 2019

Yes we should remove alipay code. But added this PR to update the dependencies if anyone use in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants