Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save deg p #66

Merged
merged 4 commits into from
Jun 19, 2023
Merged

Fix save deg p #66

merged 4 commits into from
Jun 19, 2023

Conversation

keiyamamo
Copy link
Collaborator

Fix #61

Combination of the degree that I tested

  1. d_deg = v_deg = p_deg = save_deg = 1
  2. d_deg = v_deg = 2, p_deg = 1, save_deg = 1
  3. d_deg = v_deg = 2, p_deg = 1, save_deg = 2

I tried to test higher order elements like P3P3P2 but Newton solver diverged on my laptop.

@keiyamamo keiyamamo changed the title Fix save dev p Fix save deg p Jun 15, 2023
@keiyamamo
Copy link
Collaborator Author

Tested against

  1. d_deg = v_deg = p_deg = save_deg = 1
  2. d_deg = v_deg = 2, p_deg = save_deg = 1
  3. d_deg = v_deg = 2, p_deg = 1, save_deg = 2
  4. d_deg = v_deg = p_deg = save_deg = 2

and confirmed that all visualization looked as it should. I decided to add a check that raise an error when save_deg is larger than the v_deg. I will merge now but please feel free to ask questions or give me feedback.

@keiyamamo keiyamamo merged commit 542c234 into KVSlab:master Jun 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressure should not be part of save_deg >1 ?
1 participant