-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for Meshes in [weakdeps] to 0.50, (keep existing compat) #80
Merged
JoshuaLampert
merged 1 commit into
compathelper/new_version/2024-08-29-00-46-17-991-00172481368
from
compathelper/new_version/2024-08-29-00-45-09-108-04216299192
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
compathelper/new_version/2024-08-29-00-45-09-108-04216299192
branch
from
August 29, 2024 00:45
0802fba
to
a5d866a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## compathelper/new_version/2024-08-29-00-46-17-991-00172481368 #80 +/- ##
===============================================================================================
Coverage ? 98.59%
===============================================================================================
Files ? 40
Lines ? 1137
Branches ? 0
===============================================================================================
Hits ? 1121
Misses ? 16
Partials ? 0 ☔ View full report in Codecov by Sentry. |
JoshuaLampert
changed the base branch from
main
to
compathelper/new_version/2024-08-29-00-45-45-203-03709129860
August 29, 2024 07:56
JoshuaLampert
changed the base branch from
compathelper/new_version/2024-08-29-00-45-45-203-03709129860
to
compathelper/new_version/2024-08-29-00-46-17-991-00172481368
August 29, 2024 07:58
JoshuaLampert
approved these changes
Aug 29, 2024
JoshuaLampert
merged commit Aug 29, 2024
19fa344
into
compathelper/new_version/2024-08-29-00-46-17-991-00172481368
15 checks passed
JoshuaLampert
deleted the
compathelper/new_version/2024-08-29-00-45-09-108-04216299192
branch
August 29, 2024 07:58
JoshuaLampert
pushed a commit
that referenced
this pull request
Aug 29, 2024
…existing compat) (#82) * CompatHelper: bump compat for Meshes to 0.50 for package test, (keep existing compat) * CompatHelper: bump compat for Meshes in [weakdeps] to 0.50, (keep existing compat) (#80) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> --------- Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
JoshuaLampert
pushed a commit
that referenced
this pull request
Aug 29, 2024
…existing compat) (#81) * CompatHelper: bump compat for Meshes to 0.50 for package docs, (keep existing compat) * CompatHelper: bump compat for Meshes to 0.50 for package test, (keep existing compat) (#82) * CompatHelper: bump compat for Meshes to 0.50 for package test, (keep existing compat) * CompatHelper: bump compat for Meshes in [weakdeps] to 0.50, (keep existing compat) (#80) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> --------- Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Meshes
package from0.46, 0.47, 0.48, 0.49
to0.46, 0.47, 0.48, 0.49, 0.50
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.