Skip to content

Commit

Permalink
fix: fixed items
Browse files Browse the repository at this point in the history
  • Loading branch information
@JohnnyTheTank
JohnnyTheTank committed Jan 11, 2016
1 parent ec17ee8 commit a54434f
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 19 deletions.
2 changes: 1 addition & 1 deletion bower.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"authors": [
"Jonathan Hornung <jonathan.hornung@gmail.com>"
],
"version": "0.7.6",
"version": "0.7.7",
"description": "GitHub plugin for apiNG",
"main": "dist/aping-plugin-github.min.js",
"moduleType": [],
Expand Down
15 changes: 7 additions & 8 deletions dist/aping-plugin-github.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/**
@name: aping-plugin-github
@version: 0.7.6 (11-01-2016)
@version: 0.7.7 (11-01-2016)
@author: Jonathan Hornung
@url: https://github.com/JohnnyTheTank/apiNG-plugin-github
@license: MIT
Expand All @@ -16,7 +16,7 @@ var jjtApingGithub = angular.module("jtt_aping_github", ['jtt_github'])
link: function (scope, element, attrs, apingController) {

var appSettings = apingController.getAppSettings();
var requests = apingUtilityHelper.parseJsonFromAttributes(attrs.apingGithub, apingGithubHelper.getThisPlattformString(), appSettings);
var requests = apingUtilityHelper.parseJsonFromAttributes(attrs.apingGithub, apingGithubHelper.getThisPlatformString(), appSettings);

requests.forEach(function (request) {

Expand All @@ -32,7 +32,7 @@ var jjtApingGithub = angular.module("jtt_aping_github", ['jtt_github'])

//create requestObject for api request call
var requestObject = {
access_token: apingUtilityHelper.getApiCredentials(apingGithubHelper.getThisPlattformString(), "access_token"),
access_token: apingUtilityHelper.getApiCredentials(apingGithubHelper.getThisPlatformString(), "access_token"),
};

if (typeof request.items !== "undefined") {
Expand All @@ -41,7 +41,7 @@ var jjtApingGithub = angular.module("jtt_aping_github", ['jtt_github'])
requestObject.per_page = appSettings.items;
}

if (requestObject.count === 0 || requestObject.count === '0') {
if (requestObject.per_page === 0 || requestObject.per_page === '0') {
return false;
}

Expand Down Expand Up @@ -112,7 +112,7 @@ var jjtApingGithub = angular.module("jtt_aping_github", ['jtt_github'])
}]);;"use strict";

jjtApingGithub.service('apingGithubHelper', ['apingModels', 'apingTimeHelper', 'apingUtilityHelper', function (apingModels, apingTimeHelper, apingUtilityHelper) {
this.getThisPlattformString = function () {
this.getThisPlatformString = function () {
return "github";
};

Expand Down Expand Up @@ -191,7 +191,7 @@ jjtApingGithub.service('apingGithubHelper', ['apingModels', 'apingTimeHelper', '
};

this.getRepoItemByJsonData = function (_item) {
var repoObject = apingModels.getNew("repo", this.getThisPlattformString());
var repoObject = apingModels.getNew("repo", this.getThisPlatformString());

$.extend(true, repoObject, {
owner_name: _item.owner ? _item.owner.login : undefined,
Expand Down Expand Up @@ -226,7 +226,7 @@ jjtApingGithub.service('apingGithubHelper', ['apingModels', 'apingTimeHelper', '
};
/*
this.getActivityItemByJsonData = function (_item) {
var activityObject = apingModels.getNew("activity", this.getThisPlattformString());
var activityObject = apingModels.getNew("activity", this.getThisPlatformString());
$.extend(true, activityObject, {
body : undefined,
Expand Down Expand Up @@ -304,7 +304,6 @@ jjtApingGithub.service('apingGithubHelper', ['apingModels', 'apingTimeHelper', '
return returnObject;
};
*/

}]);;"use strict";

angular.module("jtt_github", [])
Expand Down
4 changes: 2 additions & 2 deletions dist/aping-plugin-github.min.js
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "aping-plugin-github",
"version": "0.7.6",
"version": "0.7.7",
"description": "GitHub plugin for apiNG",
"main": "dist/aping-plugin-github.min.js",
"scripts": {
Expand Down
6 changes: 3 additions & 3 deletions src/aping-github-directive.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ var jjtApingGithub = angular.module("jtt_aping_github", ['jtt_github'])
link: function (scope, element, attrs, apingController) {

var appSettings = apingController.getAppSettings();
var requests = apingUtilityHelper.parseJsonFromAttributes(attrs.apingGithub, apingGithubHelper.getThisPlattformString(), appSettings);
var requests = apingUtilityHelper.parseJsonFromAttributes(attrs.apingGithub, apingGithubHelper.getThisPlatformString(), appSettings);

requests.forEach(function (request) {

Expand All @@ -25,7 +25,7 @@ var jjtApingGithub = angular.module("jtt_aping_github", ['jtt_github'])

//create requestObject for api request call
var requestObject = {
access_token: apingUtilityHelper.getApiCredentials(apingGithubHelper.getThisPlattformString(), "access_token"),
access_token: apingUtilityHelper.getApiCredentials(apingGithubHelper.getThisPlatformString(), "access_token"),
};

if (typeof request.items !== "undefined") {
Expand All @@ -34,7 +34,7 @@ var jjtApingGithub = angular.module("jtt_aping_github", ['jtt_github'])
requestObject.per_page = appSettings.items;
}

if (requestObject.count === 0 || requestObject.count === '0') {
if (requestObject.per_page === 0 || requestObject.per_page === '0') {
return false;
}

Expand Down
7 changes: 3 additions & 4 deletions src/aping-github-helper.js
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use strict";

jjtApingGithub.service('apingGithubHelper', ['apingModels', 'apingTimeHelper', 'apingUtilityHelper', function (apingModels, apingTimeHelper, apingUtilityHelper) {
this.getThisPlattformString = function () {
this.getThisPlatformString = function () {
return "github";
};

Expand Down Expand Up @@ -80,7 +80,7 @@ jjtApingGithub.service('apingGithubHelper', ['apingModels', 'apingTimeHelper', '
};

this.getRepoItemByJsonData = function (_item) {
var repoObject = apingModels.getNew("repo", this.getThisPlattformString());
var repoObject = apingModels.getNew("repo", this.getThisPlatformString());

$.extend(true, repoObject, {
owner_name: _item.owner ? _item.owner.login : undefined,
Expand Down Expand Up @@ -115,7 +115,7 @@ jjtApingGithub.service('apingGithubHelper', ['apingModels', 'apingTimeHelper', '
};
/*
this.getActivityItemByJsonData = function (_item) {
var activityObject = apingModels.getNew("activity", this.getThisPlattformString());
var activityObject = apingModels.getNew("activity", this.getThisPlatformString());
$.extend(true, activityObject, {
body : undefined,
Expand Down Expand Up @@ -193,5 +193,4 @@ jjtApingGithub.service('apingGithubHelper', ['apingModels', 'apingTimeHelper', '
return returnObject;
};
*/

}]);

0 comments on commit a54434f

Please sign in to comment.