Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support banned relative imports #25

Merged
merged 13 commits into from
May 22, 2024
Merged

Support banned relative imports #25

merged 13 commits into from
May 22, 2024

Conversation

tomkad99
Copy link
Collaborator

@tomkad99 tomkad99 commented Jan 31, 2023 •
edited
Loading

iShot_2024-05-09_15 22 32

@tomkad99 tomkad99 marked this pull request as ready for review February 6, 2023 07:16
@bvoq
Copy link

bvoq commented Mar 20, 2024

Hello, any updates on this from iteo?
Relative imports would make your code a lot more useful for projects with existing relative imports!

@mbeskaiteo mbeskaiteo force-pushed the feature/support-relative-imports branch 2 times, most recently from bd0aa17 to 9938bcd Compare March 21, 2024 09:05
@mbeskaiteo mbeskaiteo force-pushed the feature/support-relative-imports branch from 9938bcd to 0e73182 Compare March 21, 2024 10:32
@tomkad99
Copy link
Collaborator Author

@bvoq Hi,

Thanks for showing interest :)

We will try to finish that feature in few days.

@tomkad99
Copy link
Collaborator Author

tomkad99 commented Apr 9, 2024

@bvoq Hi,

After some research it turns out that we must update to the newer analyzer what will take more time.

Due to that, it is not possible to finish this feature quickly.

LukaszWojcikIteo
LukaszWojcikIteo requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@LukaszWojcikIteo LukaszWojcikIteo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing version bump in tools/analyzer_plugin/pubspec.yaml

@tomkad99 tomkad99 merged commit 9d53b73 into main May 22, 2024
2 checks passed
@tomkad99
Copy link
Collaborator Author

@bvoq The new changes are ready to check from main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RSC-88 RSC-88 RSC-88 approved these changes

@LukaszWojcikIteo LukaszWojcikIteo LukaszWojcikIteo approved these changes

@Antriadus Antriadus Awaiting requested review from Antriadus

@Axot017 Axot017 Awaiting requested review from Axot017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomkad99 @bvoq @RSC-88 @LukaszWojcikIteo