This repository has been archived by the owner on Jun 20, 2022. It is now read-only.
#384 dynamically disable speed of symptoms #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabrandes
approved these changes
May 29, 2020
There was a problem hiding this comment.
Sieht für mich grundsätzlich gut aus. Ich bin nur ein bisschen verblüfft, dass die Ausbruchsgeschwindigkeit nicht auch Teil von SymptomForm ist, da es ja eng damit zusammenhängt. Wäre dem so müssten keine Custom Events nach außen geleitet werden, die von allen einbettenden Formularen wiederum selbst behandelt werden müssen. Wenn du magst kannst du dir das ja nochmal anschauen. Falls nicht ist das auch OK, den Approve bekommst du trotzdem 👍😃
|
➡️ Live preview at url: https://imis-pr-451-lfq7hnbpwq-ew.a.run.app 🆙 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #384
Falls euch noch eine schönere Möglichkeit einfällt, gerne her damit. Computed funktioniert nur bei form fields nicht, da sich die Referenz auf form ja nicht ändert. v-model geht auch nicht, da ich ja das Formularfeld für speedOfSymptomsOutbreak clearen soll, wenn das Feld deaktiviert wird.