remove build dependency on DXSDK and dxguid.lib in favor of using InitGuid.h #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanpasu64
added a commit
to nyanpasu64/j0CC-FamiTracker
that referenced
this pull request
May 25, 2020
Switch to InitGuid.h instead. Based on HertzDevil/0CC-FamiTracker#83 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not actually sure this works properly if building on Windows XP or with older versions of Visual Studio, but it does work correctly with Visual Studio Community 2017, and means you no longer have to explicitly install the DirectX SDK (from March 2009?) to build 0CC-Famitracker.